Add Amazon shipping endpoint #353
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen293
force-pushed
the
amazon_shipping
branch
from
cea7572 to
2b48510
Compare
jchen293
changed the title
Justintime50
approved these changes
Dec 17, 2024
| @@ -36,6 +36,9 @@ | |||
| "FedexAccount", | |||
| "FedexSmartpostAccount", | |||
| ] | |||
| _CARRIER_ACCOUNT_TYPES_WITH_CUSTOM_OAUTH = [ | |||
There was a problem hiding this comment.
question: do we know if other carriers will reuse this same endpoint? Otherwise this name may be too generic
There was a problem hiding this comment.
I don't know; there could be a carrier that uses this endpoint in the future. This name is similar to what we have for FedEx _CARRIER_ACCOUNT_TYPES_WITH_CUSTOM_WORKFLOWS
nwithan8
approved these changes
Dec 18, 2024
|
Putting this PR to draft until we finalize the update endpoint in Q1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Routes
AmazonShippingAccountcreate/update requests to the new/register_oauthendpointTesting
Added new unit tests
Pull Request Type
Please select the option(s) that are relevant to this PR.