Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6554: Removing fix for pretty url filters as it breaks render… #6634

Open
wants to merge 5 commits into
base: 4.x
Choose a base branch
from
Open

fixes #6554: Removing fix for pretty url filters as it breaks render… #6634

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2fcfa5
feature/6554: Removing fix for pretty url filters as it breaks render…
kadiiski Dec 9, 2024
5b983d7
feature/6554: fixing lint error.
kadiiski Dec 9, 2024
13690b3
feature/6554: fixing lint error.
kadiiski Dec 9, 2024
9ba0560
Removing commented code as suggested for best practices.
kadiiski Dec 11, 2024
3d80aa3
Update src/Field/Configurator/BooleanConfigurator.php
kadiiski Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Field/Configurator/BooleanConfigurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,10 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
if ($isRenderedAsSwitch) {
// this happens when processing fields not for a specific entity (e.g. when
// rendering the filters from the 'index' page)
kadiiski marked this conversation as resolved.
Show resolved Hide resolved
if (null === $entityDto->getPrimaryKeyValue()) {
$field->setCustomOption(BooleanField::OPTION_RENDER_AS_SWITCH, false);

return;
}
// if (null === $entityDto->getPrimaryKeyValue()) {
// $field->setCustomOption(BooleanField::OPTION_RENDER_AS_SWITCH, false);ю
// return;
// }
kadiiski marked this conversation as resolved.
Show resolved Hide resolved

$crudDto = $context->getCrud();

Expand Down
Loading