Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix finding selected enum value in choices #5997

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fix finding selected enum value in choices #5997

merged 1 commit into from
Nov 1, 2023

Conversation

klkvsk
Copy link
Contributor

@klkvsk klkvsk commented Nov 1, 2023 •
edited by OskarStark
Loading

Fix #5984

@klkvsk klkvsk force-pushed the 5984-fix-choice-enum branch 3 times, most recently from 4eb465a to a94b7a0 Compare November 1, 2023 00:16
@klkvsk klkvsk changed the title #5984 fix finding selected enum value in choices #5984 fix finding selected enum value in choices Nov 1, 2023
bytes-commerce
bytes-commerce reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@bytes-commerce bytes-commerce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in Resources/public are probably not meant to be commited, I guess. Can you check and remove them if they are not part of this PR?

src/Field/Configurator/ChoiceConfigurator.php Outdated Show resolved Hide resolved
@klkvsk klkvsk force-pushed the 5984-fix-choice-enum branch from a94b7a0 to e7e33bb Compare November 1, 2023 13:02
@klkvsk
Copy link
Contributor Author

klkvsk commented Nov 1, 2023

Sorry bout that, trying out gh codespaces gave me hard time :D
Looks good now?

@OskarStark OskarStark changed the title #5984 fix finding selected enum value in choices Fix finding selected enum value in choices Nov 1, 2023
@javiereguiluz javiereguiluz added this to the 4.x milestone Nov 1, 2023
@javiereguiluz
Copy link
Collaborator

Thanks @klkvsk. We've tried to fix enums support in choice fields several times, so I hope your fix is the definitive fix. Thanks.

@javiereguiluz javiereguiluz merged commit 9064cc7 into EasyCorp:4.x Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytes-commerce bytes-commerce bytes-commerce approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

ChoiceField multiple with Enum
3 participants
@klkvsk @javiereguiluz @bytes-commerce