Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix untranslateable Help texts in crud view. #5973

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix untranslateable Help texts in crud view. #5973

merged 1 commit into from
Oct 26, 2023

Conversation

bytes-commerce
Copy link
Contributor

@bytes-commerce bytes-commerce commented Oct 24, 2023 •
edited
Loading

This configuration in a CrudController (1) leads to this result (2). The expected output however is a translated/translatable help line (3).

This PR will allow Help texts to be translated properly with the given parameters in a Crud overview.

  1. Code Configuration in Crud:
    grafik

  2. Result:
    grafik

  3. Expectation (the Help is translated)
    grafik

Bug is reproducible in 4.8.0 tag.

This PR allows for both usage of t() method and plain inputs to be translated by the Symfony translator automatically.

jmariller
jmariller approved these changes Oct 26, 2023
View reviewed changes
Copy link

@jmariller jmariller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, I just found about it on my side too and was about to propose something similar :)

@javiereguiluz javiereguiluz added this to the 4.x milestone Oct 26, 2023
@javiereguiluz
Copy link
Collaborator

Thanks for fixing this bug Max.

@javiereguiluz javiereguiluz merged commit 33a94b7 into EasyCorp:4.x Oct 26, 2023
19 checks passed
@bytes-commerce
Copy link
Contributor Author

Very happy to contribute to this amazing project of yours. ❤️‍🔥

@javiereguiluz javiereguiluz mentioned this pull request Oct 27, 2023
Merged
javiereguiluz added a commit that referenced this pull request Oct 27, 2023
@javiereguiluz
bug #5982 Fix the rendering of HTML contents in translated help messa…
925e2a0 
…ges (javiereguiluz)

This PR was squashed before being merged into the 4.x branch.

Discussion
----------

Fix the rendering of HTML contents in translated help messages

Fixes a minor issue introduced in #5973.

Commits
-------

4b170b9 Fix the rendering of HTML contents in translated help messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmariller jmariller jmariller approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@bytes-commerce @javiereguiluz @jmariller