Fix leftover in services where constructor dont regonise this parameter #5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdbeek
referenced
this pull request
Oct 24, 2023
…eguiluz) This PR was squashed before being merged into the 4.x branch. Discussion ---------- Added a feature to include columns inside forms This PR is BIG and includes some very important and nice changes: * You can now divide a form into columns with `FormField::addColumn()`. Combine this with form tabs and fieldsets to create super complex forms very easily. * The `detail` page FINALLY shows the SAME design as new/edit pages. Form tabs, columns, fieldsets, etc. Everything looks exactly how you expect. Finally!! If you want to review this, the most important things are: * The new `FormLayoutFactory` is the key. It transforms the form config (which is optimized for developers using EasyAdmin) into a linear list of layout + field items (which is optimized for rendering it in Twig templates and Symfony Form themes templates). * Check out the `FormLayoutFactoryTest` to see many practical examples of the work that this new class does to flatten and linearize the layout configuration. In the coming days I'm going to provide: * More and better docs about form layouts * Some design tweaks * Fixes in the code for the bugs reported by the community Thanks! Commits ------- d289100 Added a feature to include columns inside forms
|
Thanks @nvdbeek. |
|
It's fine to merge this "as si" without adding a test. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: a3f4e9a#r130786051
If you want, I can write an integration test against the extension to prevent this problem in the future