Show readonly code editor field on detail page #5969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a read-only CodeMirror for CodeEditorField on the detail page.
Assets rebuilt with
make build-assets
.Problems with this PR@javiereguiluz I need some help, if you don't mind.Unfortunately, I can't get good results fromyarn build
, so this PR is a draft until I figure that out. The patch works even without a rebuild, but a build is necessary to make the CodeMirror editor read-only.When I runyarn build
, the following problems occur:WARNING The value passed to setPublicPath() should *usually* start with "/" or be a full URL (http://...). If you're not sure, then you should probably change your public path and make this message disappear.
Themanifest.json
file refers to paths that start with/
, therefore the browser just gets 404 for everything.Removing the leading/
manually makes JS and CSS load again, but everything (and I mean everything rendered by EasyAdminBundle) is RTL, and the CodeEditor field doesn't accept input, and I'm also missing fonts