Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id attribute to batch form checkboxes #5931

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

pavol-tuka
Copy link
Contributor

A form field element should have an id or name attribute.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input

@javiereguiluz javiereguiluz added this to the 4.x milestone Sep 25, 2023
@javiereguiluz javiereguiluz merged commit c99b67d into EasyCorp:4.x Sep 25, 2023
19 checks passed
@javiereguiluz
Copy link
Collaborator

Thanks for fixing this!

I liked your contribution a lot, but I made a small change while merging: 8fc96c6 I prefer to not use the primary key value as part of the HTML id attribute for performance reasons and to avoid potential issues with people who use non-standard values as primary keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants