ability to use flysystem to manage uploaded files #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jan 9, 2023
…uel-tilleuls) This PR was merged into the 4.x branch. Discussion ---------- replace annotations by attributes in test entities The tests jobs of my previous PR (#5555) failed with errors : ``` The service "doctrine.orm.default_annotation_metadata_driver" has a dependency on a non-existent service doctrine.orm.metadata.annotation_reader". ``` This PR replaces annotations by PHP 8 attributes. This change allows tests to pass for PR #5555 (The actual code change in entities has been made by rector) Commits ------- f544918 replace annotations by attributes in test entities
emmanuel-averty
force-pushed
the
flysystem-image-upload-type
branch
from
139e66f to
ea383f4
Compare
|
Anything is blocking this PR ? |
emmanuel-averty
force-pushed
the
flysystem-image-upload-type
branch
from
ea383f4 to
877bec7
Compare
|
I think it would be better to introduce an interface along with a simple default implementation to also allow different drivers/adapters. Then maybe it would even be enough to provide some documentation about how to provide your own implementation. |
|
Thank you @mahono for this advise. You're very right. |
|
Hi @emmanuel-tilleuls. Please are going to modify PR in the future, or it is OK for you if I take care of it? Thanks a lot. |
|
Hi @pdragun. I don't have much time to take care about this PR these days. Feel free to reuse the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ImageField, the downloaded image goes to local file system. With this PR, easy admin user can configure aFilesystemOperatorin order to abstract file system and therefor choose where to put the images. It can bee anything supported by Flysystem such as S3 bucket or FTP directory.The
FilesystemOperatorinstance has to be configured with the Flysystem Symfony bundleCloses #5544