bug #6121 Fix an issue related to the translation of country names (j…

…aviereguiluz)

This PR was merged into the 4.x branch.

Discussion
----------

Fix an issue related to the translation of country names

`@psihius` reported this problem to me. When using a `CountryField`, you get hundreds of "missing translation" errors. We already pass the country names translated to the form, so there's no need to try to translate them again.

Commits
-------

03150db Fix an issue related to the translation of country names

src/Field/Configurator/CountryConfigurator.php

@@ -41,6 +41,8 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
         }
 
         if (\in_array($context->getCrud()->getCurrentPage(), [Crud::PAGE_EDIT, Crud::PAGE_NEW], true)) {
+            // country names passed to the form are already translated, so don't translate them again in the template
+            $field->setFormTypeOptionIfNotSet('choice_translation_domain', false);
             $field->setFormTypeOption('choices', $this->generateFormTypeChoices($countryCodeFormat, $field->getCustomOption(CountryField::OPTION_COUNTRY_CODES_TO_KEEP), $field->getCustomOption(CountryField::OPTION_COUNTRY_CODES_TO_REMOVE)));
 
             // the value of this form option must be a string to properly propagate it as an HTML attribute value