-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added various fixes for hybrid pressure coordinates #529
Conversation
cc2e09c
to
9c0abdf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f0643c1
to
0dfb43c
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, did not review the tests yet.
0dfb43c
to
8b10380
Compare
@zklaus I rebased the master and added your suggestions. Please not that I intentionally did not use from ..common import ClFixHybridPressureCoord as Cl but from ..common import ClFixHybridPressureCoord
Cl = ClFixHybridPressureCoord for two reasons: First, to mute Codacy and second, to make it clearer that there is a fix for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check all tests in detail, but to me it seems fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Added various fixes for CMIP5 and CMIP6 models concerning hybrid pressure coordinates (variables
cl
,cli
andclw
).Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Related to #536, #540, #541, #542. (Note: Automatic closing of these issues is not desired; they should be closed when the issue is reported to the modelers).