Missing 2m height coordinate and monotonicity for tasmin in CESM2 and CESM2-WACCM #2574
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2574 +/- ##
==========================================
- Coverage 94.66% 94.65% -0.01%
==========================================
Files 251 251
Lines 14286 14288 +2
==========================================
+ Hits 13524 13525 +1
- Misses 762 763 +1 ☔ View full report in Codecov by Sentry. |
Karen-A-Garcia
changed the title
|
Thanks @valeriupredoi and thanks for showing me a similar fix for the monotonicity too. I've added a fix for the monotonicity as well as adding tests for them and I ran pre-commit before sending pushing the changes. Let me know if there's anything else I need to change. |
There was a problem hiding this comment.
many thanks @Karen-A-Garcia 🍺 A few wiggles to fix (am not 100% sure of the baseclass for Tasmin for CESM2, I think it should be a generic Fix class there, doesn't really matter that much). One general comment related to testing: it's great that you added tests, this is always a good thing to see from users, but wrt the testing framework, I'd suggest using the Pytest test classes/functions, and not use Unittest test classes anymore - these are old school and a tad harder to adapt inside a Pytest testing framework, plus, they need a lot more indentation 😁
| @@ -286,3 +287,80 @@ def fix_metadata(self, cubes): | |||
| if z_coord.standard_name is None: | |||
| fix_ocean_depth_coord(cube) | |||
| return cubes | |||
|
|
|||
|
|
|||
| class Tasmin(Tas): | |||
There was a problem hiding this comment.
| class Tasmin(Tas): | |
| class Tasmin(Fix): |
There was a problem hiding this comment.
I think the base class should be Fix here
| def test_get(self): | ||
| """Test fix get.""" | ||
| self.assertListEqual( | ||
| Fix.get_fixes("CMIP6", "NCAR", "day", "tasmin"), |
There was a problem hiding this comment.
| Fix.get_fixes("CMIP6", "NCAR", "day", "tasmin"), | |
| Fix.get_fixes("CMIP6", "CESM2", "day", "tasmin"), |
| """Test fix get.""" | ||
| self.assertListEqual( | ||
| Fix.get_fixes("CMIP6", "NCAR", "day", "tasmin"), | ||
| [Tasmin(None)], |
There was a problem hiding this comment.
| [Tasmin(None)], | |
| [Tasmin(None), GenericFix(None)], |
| def test_get(self): | ||
| """Test fix get.""" | ||
| self.assertListEqual( | ||
| Fix.get_fixes("CMIP6", "NCAR", "day", "tasmin"), |
There was a problem hiding this comment.
| Fix.get_fixes("CMIP6", "NCAR", "day", "tasmin"), | |
| Fix.get_fixes("CMIP6", "CESM2-WACCM", "day", "tasmin"), |
| """Test fix get.""" | ||
| self.assertListEqual( | ||
| Fix.get_fixes("CMIP6", "NCAR", "day", "tasmin"), | ||
| [Tasmin(None)], |
There was a problem hiding this comment.
| [Tasmin(None)], | |
| [Tasmin(None), GenericFix(None)], |
This is a follow up to issue #2573 for the height coordinates. Still looking into the time issue. There was already a fix for the 2m height previously done for tas and I simply applied the fix to tasmin in both CESM2 and CESM2-WACCM files. There were already tests written for the fixes so I didn't add anything to those files.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.