Explicitly cast to str a few cube and cubes instances in _io.py
#2526
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
whoa!! Who's activated Precommit on PRs again? @bouweandela that you, bud? |
|
Sorry about that. Here is a pull request to disable the automatic commits: #2527 |
cheers bud! Let me revert that PC commit now then |
This reverts commit f905f39.
for more information, see https://pre-commit.ci
This reverts commit 7196f16.
|
OK that wildebeest is now gone, for good 😁 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 251 251
Lines 14191 14191
=======================================
Hits 13458 13458
Misses 733 733 ☔ View full report in Codecov by Sentry. |
|
converting this to Draft since it may need more stuff, depending what @rswamina finds out on JASMIN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found out in ESMValGroup/ESMValTool#3738 that one particular call to
logger.debughangs the run if thecubeobject it needs to print out is not explicitly cast tostr- as @rswamina asks - why this happens only for certain datasets, and not for all, the answer is "beats me", but the run hanging is 100% due to this issue, and is perfectly reproducible on JASMIN (not elsewhere) - so I guess it's a combination oflocaleand the particularcubethat needs be debug logged. At any rate, this fixes a problem that we don't really know the cause of, but fixes it does 😁Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: