Avoid copying input data in CMIP6 CESM2 air pressure level fixes #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very cool @bouweandela 👏 Always nice to see data transfer optimizations, hope you don't mind me turning on the GA see if any issues for older Pythons - I took a look at the failed tests - couple of them due to mocks not called (easy fix) but one fails due to what looks to be a reversal of the lev bounds, can prob fix that for you here, if you don't have time 🍺 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2454 +/- ##
=======================================
Coverage 94.77% 94.78%
=======================================
Files 251 251
Lines 14266 14292 +26
=======================================
+ Hits 13520 13546 +26
Misses 746 746 ☔ View full report in Codecov by Sentry. |
Enable lock sharing between ncdata and Iris Suppress load warnings Restore lat/lon coord units after load All fixes in fix_file
|
TODO: move to new What about chunking? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use ncdata to fix files in-memory instead of copies on disk.
Related to #2129 and #674
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: