Allows relative paths for diagnostic scripts. #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage 94.76% 94.77%
=======================================
Files 251 251
Lines 14280 14282 +2
=======================================
+ Hits 13533 13536 +3
+ Misses 747 746 -1 ☔ View full report in Codecov by Sentry. |
|
@rbeucher would you be able to run pre-commit on this one please, mate? I'll have a look after - my sincere apologies, no idea why I made this PR wait for so long |
…Core into run_local_diagnostics
|
@valeriupredoi , this one should be good to go |
flicj191
reviewed
Nov 15, 2024
| # Try diagnostics_root | ||
| script_file = ( | ||
| diagnostics_root / Path(script).expanduser() | ||
| ).absolute() |
There was a problem hiding this comment.
should we add to the error message that another path was tried?
err_msg += f" or ({script_file})"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2328
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: