Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3iogomd.F90: fix IF-stmt indention #20

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Mar 19, 2024

Pull Request Summary

Indent formatting for IF-block keywords in w3iogomd.F90.

Description

  • Provide a detailed description of what this PR does.
    • Corrects some IF/ENDIF statements that were out of alignment, to be aligned.
  • What bug does it fix, or what feature does it add?
    • Fixes formatting.
  • Is a change of answers expected from this PR?
    • No.

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added:
    • NA
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply:
    • No answer changes expected.

Issue(s) addressed

Commit Message

w3iogomd.F90: fix IF-stmt indention

Check list

Testing

  • How were these changes tested?
    • The suite of coupled UFS RT's was run as a sanity check.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • No we don't test for formatting.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • Standalone has passed a number of times before. In this case, for formatting, just a sanity check was in order.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    • None expected.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@MatthewMasarik-NOAA
Copy link
Collaborator Author

Fyi, @DeniseWorthen @alperaltuntas @JessicaMeixner-NOAA

I'll submit this as full PR tomorrow. I currently have some sanity checks going. The PR will address Denise's request on the main pr, NOAA-EMC/pull/1034.

@alperaltuntas, this will require your approval/merge. I'll request a review from you tomorrow once I get everything lined up.

@MatthewMasarik-NOAA
Copy link
Collaborator Author

Fyi, @DeniseWorthen @alperaltuntas @JessicaMeixner-NOAA

This is ready to move forward. I've attached a hera RT log to the header for a sanity check.

@alperaltuntas, could you review when you have a chance?

@alperaltuntas alperaltuntas merged commit 32611c5 into ESCOMP:sync-dev/unified Mar 20, 2024
@MatthewMasarik-NOAA
Copy link
Collaborator Author

Thanks @alperaltuntas! 👍

@DeniseWorthen
Copy link

Thanks @alperaltuntas and @MatthewMasarik-NOAA

@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the format/sync-dev/unified branch March 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants