Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langmuir turbulence PR - additions #10

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Jul 19, 2023

Pull Request Summary

Implements requested changes for Draft PR: NOAA-EMC/pull/1034

Description

The following changes have been requested during initial review by @JessicaMeixner-NOAA:

  • add relevant *.inp, *.nml for implemented functionality
  • add regtest(s) demonstrating functionality
  • add documentation

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added: bug, documentation, enhancement, new feature
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply: mod_def change, out_grd change, out_pnt change, restart file change, Regression test
    -->

Issue(s) addressed

Commit Message

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@MatthewMasarik-NOAA
Copy link
Collaborator Author

Fyi, @alperaltuntas I've started this draft PR to your PR. This is just a placeholder to get started. I'll work on the first two checkboxes, then we can circle back to take care of the documentation. Once that's done, I'll make this a PR ready for review and we can go from there.

@MatthewMasarik-NOAA
Copy link
Collaborator Author

This branch is outdated. A new PR has just been submitted, #11. The new PR will go forward, and this will be closed now.

@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the unified/additions branch September 20, 2023 20:35
francescococetta pushed a commit to francescococetta/WW3 that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant