-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on explicit AC, Leung_2023, and excess ice by default #2724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be asking too early, but we want both excess ice and dust only changed for clm6_0 physics.
While we finalize the finidat question, I will start some tests: ./build-namelist_test.pl has this expected failure:
|
…ns_chging_tag_1 Conflicts: bld/namelist_files/namelist_defaults_ctsm.xml
Merging ctsm5.2.025
@slevis-lmwg and I went over this. This has everything in place needed here. The card mentions maybe adding explicit testing for A/C. It's true we don't have that, but it will be turned on for clm6_0 and off for clm5_0 and clm4_5, so on and off are exercised. |
@ekluzek thank you for your help with this |
./build-namelist_test.pl OK, expected failure: Test Id: 525> <Desc: LeungDust_WO_Prigent
|
Description of changes
Pull Request for Answer-changing tag described in this card:
https://github.com/orgs/ESCOMP/projects/46/views/1?pane=issue&itemId=75893526
Specific notes
Contributors other than yourself, if any:
@ekluzek @wwieder
CTSM Issues Fixed (include github issue #):
Fixes #2466
Fixes #2568
Are answers expected to change (and if so in what way)?
Yes.
Any User Interface Changes (namelist or namelist defaults changes)?
Changed namelist defaults to make these items ON by default.
Does this create a need to change or add documentation? Did you do so?
Not me :-)
Testing performed, if any:
Not started.