Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on explicit AC, Leung_2023, and excess ice by default #2724

Merged
merged 12 commits into from
Aug 24, 2024

Conversation

slevis-lmwg
Copy link
Contributor

Description of changes

Pull Request for Answer-changing tag described in this card:
https://github.com/orgs/ESCOMP/projects/46/views/1?pane=issue&itemId=75893526

Specific notes

Contributors other than yourself, if any:
@ekluzek @wwieder

CTSM Issues Fixed (include github issue #):
Fixes #2466
Fixes #2568

Are answers expected to change (and if so in what way)?
Yes.

Any User Interface Changes (namelist or namelist defaults changes)?
Changed namelist defaults to make these items ON by default.

Does this create a need to change or add documentation? Did you do so?
Not me :-)

Testing performed, if any:
Not started.

@slevis-lmwg slevis-lmwg self-assigned this Aug 22, 2024
@slevis-lmwg slevis-lmwg added the priority: Immediate Highest priority, something that was unexpected label Aug 22, 2024
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be asking too early, but we want both excess ice and dust only changed for clm6_0 physics.

bld/namelist_files/namelist_defaults_ctsm.xml Outdated Show resolved Hide resolved
bld/namelist_files/namelist_defaults_dust_emis.xml Outdated Show resolved Hide resolved
bld/namelist_files/namelist_defaults_ctsm.xml Show resolved Hide resolved
@slevis-lmwg
Copy link
Contributor Author

While we finalize the finidat question, I will start some tests:

./build-namelist_test.pl has this expected failure:
525/3339 < FAIL> <Test Id: 525> <Desc: LeungDust_WO_Prigent>

./run_sys_tests -s aux_clm -c ctsm5.2.024 --skip-generate
on izumi for now

@ekluzek ekluzek marked this pull request as ready for review August 23, 2024 20:07
@ekluzek ekluzek added this to the cesm3_0_beta03 milestone Aug 23, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Aug 23, 2024

@slevis-lmwg and I went over this. This has everything in place needed here.

The card mentions maybe adding explicit testing for A/C. It's true we don't have that, but it will be turned on for clm6_0 and off for clm5_0 and clm4_5, so on and off are exercised.

@slevis-lmwg
Copy link
Contributor Author

@ekluzek thank you for your help with this

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Aug 23, 2024

./build-namelist_test.pl OK, expected failure: Test Id: 525> <Desc: LeungDust_WO_Prigent

./run_sys_tests -s aux_clm -c ctsm5.2.025 -g ctsm5.2.026
izumi OK
derecho OK
Added use_init_interp = .true. and ran SMS_Lm13_PS.f19_g17.I2000Clm60BgcCrop.derecho_intel.clm-cropMonthOutput manually OK (diff from baseline)

@slevis-lmwg slevis-lmwg merged commit 2b28850 into ESCOMP:master Aug 24, 2024
2 checks passed
@slevis-lmwg slevis-lmwg deleted the ans_chging_tag_1 branch August 24, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: Immediate Highest priority, something that was unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn on Leung_2024 dust emission scheme by default for clm6_0 Turn excess ice on by default in CESM3
3 participants