Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dust control in cmeps #2538

Closed
wants to merge 0 commits into from
Closed

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented May 9, 2024

Description of changes

Remove the dust emissions namelist items from CTSM and use the namelist in the drv_flds_in for CMEPS. Also
update the CMEPS version to handle this.

This updates CTSM to use the namelist control in CMEPS (in ESCOMP/CMEPS#429). So the CMEPS external needs to be updated, and the namelist control in CTSM changed to use CMEPS rather than the internal CTSM control settings and the CTSM ones removed.

Add a unit test for the CMEPS code to make sure it's working correctly.

  • unit test
  • Add drv_flds_in namelist definition in CMEPS
  • Finalize CMEPS tag point to it here
  • Update drv_flds_in namelist definition in CTSM
  • Add capability to set the dust emissions settings in drv_flds_in
  • Update build-namelist tester to get the new capability working
  • Remove the old dust namelist items in CTSM
  • Run standard testing and make sure everything is working

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #2376
Fixes #2150
Fixes #2170
Fixes #2524

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)?
Namelist items removed from CTSM and into the drv_flds_in namelist in CMEPS

Testing performed, if any: will run standard testing, have run a few singleton tests so far

@ekluzek ekluzek self-assigned this May 9, 2024
@ekluzek ekluzek changed the base branch from master to b4b-dev May 9, 2024 22:30
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability code health improving internal code structure to make easier to maintain (sustainability) labels May 9, 2024
@ekluzek ekluzek added this to the 2024 CESM June workshop milestone May 9, 2024
@ekluzek ekluzek mentioned this pull request May 9, 2024
8 tasks
@ekluzek ekluzek changed the title Dustcontrolincmeps Dust control in cmeps May 13, 2024
@ekluzek ekluzek closed this May 14, 2024
@ekluzek ekluzek mentioned this pull request May 15, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability
Projects
Status: Won't Do
1 participant