Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new physically based dust emission scheme with more aeolian physics (updated) #1897

Merged
merged 112 commits into from
Aug 11, 2024

Commits on Aug 22, 2022

  1. Apply dust branch based off of release-clm5.0.34 to dev branch

    Do a diff of the dmleung DUSTEMIS branch based off of release-clm5.0.34
    to ctsm5.1.dev106 and apply the diff after updating the paths for
    namelist_definition and lnd_import_export.F90 in the diff.
    
    git apply -3 dust.diff
    
    Diffs with conflicts:
    	modified:   src/biogeochem/DUSTMod.F90
    	modified:   src/biogeophys/SoilStateInitTimeConstMod.F90
    	modified:   src/main/controlMod.F90
    	modified:   src/cpl/mct/lnd_import_export.F90
    
    The changes in lnd_import_export were to change a check for negative
    LW that seems to be removed in the latest version.
    ekluzek committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    266cc62 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Configuration menu
    Copy the full SHA
    33dcd9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8c885a View commit details
    Browse the repository at this point in the history
  3. Always output FV

    ekluzek committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    564875e View commit details
    Browse the repository at this point in the history
  4. Make sure to distinquish history variable names as it will otherwise …

    …abort, don't output USTAR as FV is already output in FrictionVelocity
    ekluzek committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    f71bb05 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. 14 Oct 2022: dmleung edited DUSTMod to properly use LUH2 to compute h…

    …ybrid drag partitioning. (previous use of wt_lunit in DUSTMod was not working because wt_lunit was deallocated after CTSM initialization.)
    dmleung committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    fd7e5e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Add in externals to run a FHIST compset with CAM, CICE, and CICE5 fro…

    …m the cesm2_3_beta09 tag
    ekluzek committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    c7e0cf8 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. dmleung 11 Nov 2022: removed the added lines in lnd2atmMod.F90 that f…

    …orce the outgoing longwave radiation to be non-negative.
    dmleung committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    5b6d00e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Configuration menu
    Copy the full SHA
    1592ebb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    571dc5e View commit details
    Browse the repository at this point in the history
  3. set 0.1 as the minimum LAI for the Okin-Pierre drag partioning equati…

    …on; code cleanup
    
    dmleung 14 Nov 2022
    dmleung committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    db58502 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. dmleung removed outputting ustar (USTAR) in the DustMod.F90 since

    Erik enabled outputting fv (FV) in FrictionVelocityMod.F90
    14 Nov 2022
    dmleung committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    5830686 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. 31 Jan 2023: dmleung added capabilities of reading stream files for P…

    …rigent's roughness data
    dmleung committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    36d1fee View commit details
    Browse the repository at this point in the history
  2. dmleung fixed some bugs for the streams capability and further

    modified clm_instMod.F90. Now CTSM can compile successfully.
    31 Jan 2023
    dmleung committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    512c702 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Configuration menu
    Copy the full SHA
    059597c View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Configuration menu
    Copy the full SHA
    cc7696e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53ea165 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. remove the older methods of reading in prigent's roughenss data (rou…

    …gh_fct) since the stream methods is here (dmleung 31 Mar 2023)
    dmleung committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    23f44da View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    2bcfc13 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Truncate threshold crossing rate to zero, if the term going into the …

    …exp is going to be large and thus end up with a very small term
    ekluzek committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    62b7bcd View commit details
    Browse the repository at this point in the history
  2. Merge branch 'dustemis_dev' of github.com:dmleung/CTSM into dustemis_dev

     Conflicts:
    	src/biogeochem/DUSTMod.F90
    ekluzek committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    817df64 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge tag 'ctsm5.1.dev166' into dustemis_dev

    BFB merge tag dev166
    
    2315 @TeaganKing Refactoring run_neon for PLUMBER2 part1
    2326 @samsrabin run_sys_tests: Check Python environment for FatesColdTwoStream tests
    2213 @samsrabin Automatically assign high priority items to project 25
    2330 @samsrabin Add Izumi version of the aux_clm unit testing
    
     Conflicts:
    	bld/CLMBuildNamelist.pm
    	bld/namelist_files/namelist_definition_ctsm.xml
    ekluzek committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3f48309 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9208fde View commit details
    Browse the repository at this point in the history
  3. Squashed 'manage_externals/' changes from 7b6d92ef6..0f884bfec

    0f884bfec Merge pull request ESCOMP#205 from jedwards4b/sunset_svn_git_access
    82a5edf79 merge in billsacks:svn_testing_no_github
    17532c160 Use a local svn repo for testing
    9c904341a different method to determine if in tests
    539952ebd remove debug print statement
    cc5434fa7 fix submodule testing
    1d7f28840 remove broken tests
    04e94a519 provide a meaningful error message
    38bcc0a8c Merge pull request ESCOMP#201 from jedwards4b/partial_match
    b4466a5aa remove debug print statement
    c3cf3ec35 fix issue with partial branch match
    
    git-subtree-dir: manage_externals
    git-subtree-split: 0f884bfec8e43d0c02261de858d6ec3f6d855e51
    ekluzek committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    896713b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e20fb8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c4e14d1 View commit details
    Browse the repository at this point in the history
  6. Update assign-to-project.yml

    ekluzek authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    6abcc1d View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    9902724 View commit details
    Browse the repository at this point in the history
  2. Remove whitespace at end of lines, remove commented out code included…

    … commented out Zender code, remove unneeded markers by Danny Leung
    ekluzek committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    158c878 View commit details
    Browse the repository at this point in the history
  3. Add use_prigent_roughness to determine if that streams dataset needs …

    …to be read in, this is important when we need to flip between Zender and Leung
    ekluzek committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1e6d8be View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a960deb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b9d118f View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    9a05842 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8b6cb8 View commit details
    Browse the repository at this point in the history
  3. Work with some indentation, remove commented out code, add a dealloca…

    …te that was missing, add underscore to a name for readability, always allocate, but allocate only 0th element if usestreams is false
    ekluzek committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4a72a1c View commit details
    Browse the repository at this point in the history
  4. Shorten many lines (will help with nag compiler), add extra error che…

    …cking around making sure namelist is read in and stream initialization has been done, this builds and runs
    ekluzek committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3291040 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2886a18 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e2123b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. dmleung fixed many of ekluzek's comments: defining magic values into …

    …physical parameters, changing numbers into double precisions, and putting more comments into the code. 20 Feb 2024
    dmleung committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3e9d6b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fcf1fb9 View commit details
    Browse the repository at this point in the history
  3. dmleung added more comments in the code blocks for the dust emission …

    …process in the DustEmission subroutine. 20 Feb 2024
    dmleung committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b1fad33 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    4d73244 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    5aa9494 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    0c62e5b View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    942a3ae View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. dmleung: improved LAI treatment in Okin's vegetation drag partitionin…

    …g. Also added precision in other defined parameters. 26 Feb 2024
    dmleung committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c27f209 View commit details
    Browse the repository at this point in the history
  2. dmleung: Now we call the vegetation in Okin scheme VAI instead of LAI…

    …. Also set output for impact threshold. 27 Feb 2024
    dmleung committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ac5873b View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. dmleung reverted to the landunit level VAI for Okin's vegetation drag…

    … partitioning, which worked much better than the patch level VAI. 1 Apr 2024
    dmleung committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    eede6f8 View commit details
    Browse the repository at this point in the history
  2. Typo fix: Some users told me that the denominator of the dust emissio…

    …n equation in Leung 2023 should be impact threshold instead of standardized fluid threshold. So, that was corrected in the code. dmleung 1 Apr 2024
    dmleung committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    53871f4 View commit details
    Browse the repository at this point in the history
  3. Important change: Used Monin-Obukhov length to calculate the buoyancy…

    … contribution to the subtimestep wind fluctuations, instead of assuming zero buoyancy contributions. dmleung 1 Apr 2024
    dmleung committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    f488309 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    03f89ea View commit details
    Browse the repository at this point in the history
  2. dmleung added more comments on the impact of soil moisture threshold …

    …on dust emission calculation. 24 May 2024
    dmleung committed May 24, 2024
    Configuration menu
    Copy the full SHA
    956ea90 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. dmleung 28 May 2024: a small edit of DUSTMod.F90 to deal with the sit…

    …uation of dpfct_rock(p) = NaN, which likely causes the run to die when turning on debug mode
    dmleung committed May 28, 2024
    Configuration menu
    Copy the full SHA
    348c394 View commit details
    Browse the repository at this point in the history
  2. dmleung added comments on the positive denom required for dust emissi…

    …on intermittency in DUSTMod.F90. 28 May 2024
    dmleung committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f8eb462 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    573feef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    19cc556 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    65646fc View commit details
    Browse the repository at this point in the history
  4. Just fix a few typos

    ekluzek committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c90fa86 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    917baf7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3bac46 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge tag 'ctsm5.1.dev176' into dustemis_dev

    Merge b4b-dev
    
     Conflicts:
    	.github/workflows/assign-to-project.yml
    	bld/CLMBuildNamelist.pm
    	bld/namelist_files/namelist_definition_ctsm.xml
    	bld/unit_testers/build-namelist_test.pl
    	src/biogeochem/DUSTMod.F90
    ekluzek committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f579ab3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb1bd9c View commit details
    Browse the repository at this point in the history
  3. Remove abort on Leung dust method

    Add some log statements around this.
    ekluzek committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    00e3d62 View commit details
    Browse the repository at this point in the history
  4. Merge tag 'ctsm5.2.006' into dustemis_dev

    Update externals to cesm2_3_beta17, remove mct, retire /test/tools
    
    Changes unrelated to the tag's title:
    ekluzek committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d36d78e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    19f793f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Merge tag 'ctsm5.2.007' into dustemis_dev

    Rm manage_externals and update documentation accordingly
    
    Fixes ESCOMP#2537 Remove manage_externals stuff from run_sys_tests
    Fixes ESCOMP#2536 Update documentation for git-fleximod
    Fixes ESCOMP#2467 Remove references to cheyenne from the testlist
    
    NOTE: Also
    Add cam and cice to the .gitmodules file
    
     Conflicts:
    	Externals.cfg
    ekluzek committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    93dc1f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Merge tag 'branch_tags/tmp-240620.n02.ctsm5.2.007' into dustemis_dev

    Update git fleximod to resolve some issues we found with it
    
    Just update the gitfleximod subtree to v0.7.8. This fixes an issue in identifying that a tag is out of sync in a submodule.
    An issue about recursion on a submodule. Allows untracked files, and fixes a MS Window Memory error. And
    also git-fleximod status marks optional submodules, which helps explain why they are marked as not-checked out.
    
    Get unit testing working for both Leung and Zender dust emissions. Leung
    DuetEmission right now is just the Zender version. Only ran unit-testing
    at this point. Added a clean method to PrigentStreams as well as a new
    one for unit-testing.
    
     Conflicts:
    	src/biogeochem/DustEmisBase.F90
    
     	new file:   biogeochem/DustEmisLeung2023.F90
     	new file:   biogeochem/test/DustEmis_test/test_DustEmisLeung2023.pf
     	new file:   unit_test_stubs/share_esmf/PrigentRoughnessStreamType.F90
    ekluzek committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0b55728 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. dmleung add a little tuning to reduce the sensitivity of dust emissio…

    …n to clay fraction. dmleung also corrected the output of soil surface friction velocity (wnd_frc_slt). Coded on 5 Jul 2024 and committed on 8 Jul 2024
    dmleung committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1356d0b View commit details
    Browse the repository at this point in the history
  2. Merge branch 'dustemis_dev' of github.com:dmleung/CTSM into dustemis_dev

    dmleung reduced the sensitivity of dust emission to clay fraction, and corrected the output of soil surface friction velocity (wnd_frc_soil). Plus other updates from the CTSM side. dmleung coded 5 Jul 2024 and committed 8 Jul 2024
    dmleung committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b4f70ea View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    525c78b View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    21ec2ba View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'dustemis_dev' of github.com:dmleung/CTSM into dustemis_dev

     Conflicts:
    	src/biogeochem/DUSTMod.F90
    	src/biogeophys/SoilStateInitTimeConstMod.F90
    
    Also get unit tests working.
    ekluzek committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    07f4f03 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Bring in changes from Danny into the soil state functions, and update…

    … dust unit tests to use the appropriate ones for Zender and Leung tests, add tests for the new MassFracClayLeung2023 function, get the unit tests all working again
    ekluzek committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3ee7333 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Bring in actuall Leung_2023 DustEmissions subroutine, unit test fails…

    … because of change in answers
    ekluzek committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ef8acab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    667003d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. This looks wrong, but is actually correct in order to get this to wor…

    …k through initialization, otherwise it fails thinking stremas are off
    ekluzek committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0903d70 View commit details
    Browse the repository at this point in the history
  2. Get unit tests all working by adjusting the Leung 2023 test by what's…

    … doing on inside the Leung 2023 code
    ekluzek committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a58ad0f View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    b09ef39 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Add a subroutine to set drag partition for testing, label input/outpu…

    …t variables for DustEmission, remove begc/endc
    ekluzek committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e723545 View commit details
    Browse the repository at this point in the history
  2. Merge tag 'ctsm5.2.008' into dustemis_dev

    Bring tmp-branch to master
    
    Bring in changes that came in on the tmp-240620 branch to master now that cesm3_0_beta01 has been made.
    
    The changes are documented in tags and the ChangeLog but include the following tags:
    
      tmp-240620.n03.ctsm5.2.007 samrabin -- upland hillslope column fsat values to zero
      tmp-240620.n02.ctsm5.2.007 erik ------ Another update of git-fleximod
      tmp-240620.n01.ctsm5.2.007 slevis ---- Merge b4b-dev
    ekluzek committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    af3a878 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    064c37c View commit details
    Browse the repository at this point in the history
  2. Fix the error check

    ekluzek committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2e4ceb8 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    b89a829 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge tag 'ctsm5.2.018' into dustemis_dev

    Fix/excess ice cold start
    
    Changed the way soil temperature is initialized when excess ice is on and the model starts from cold.
    
    Specific notes
    
    TemperatureType now has a private ReadNL subroutine that reads two new namelist options: excess_ice_coldstart_depth and excess_ice_coldstart_temp which control top depth (higher layers get default initial temperature) and soil temperature for soil layers ONLY in columns where excess ice is present. Other columns get their default soil temperature.
    
    New namelist options belong to a new group "clm_temperature_inparm" with its own logic routine. This is done so in the future hardcoded cold start temperatures can be moved to the namelists. Two namelist tests have been added to check for invalid values logic as well as a test for use_excess_ice_streams logic. use_excess_ice_streams has no default value (due to options for restart) and default value set in the CLMBuildNamelist.pm.
    
    excessicestream_type has been taken out of waterstate_type and its routines are called directly in clm_inst%Init. Checks for UseExcessIceStreams() are still in place in WaterStateType.F90 for double-checking. clm_inst%Init now has a new local variable with excess ice concentration that are read from streams (or zeros if use_excess_ice is false). Arguments for temperature_type%Init and water_type%Init (and children types) have been changed to include this new variable. Fortran unit tests are also updated to account for these new arguments.
    
    Get the namelist and PF unit src unit tests working again
    
    Conflicts:
    	bld/CLMBuildNamelist.pm
    	bld/namelist_files/namelist_defaults_ctsm.xml
    	bld/unit_testers/build-namelist_test.pl
    	src/biogeochem/DustEmisFactory.F90
    	src/biogeochem/test/DustEmis_test/test_DustEmisZender2003.pf
    ekluzek committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    568aee4 View commit details
    Browse the repository at this point in the history
  2. Update cam and cice to version in cesm3_0_beta02, there is a gitflexi…

    …mod problem in updating to this CAM version
    ekluzek committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d0f7fc2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5084ea6 View commit details
    Browse the repository at this point in the history
  4. Add a LDust testmod and tests for it

    Add a testmod for running Leung_2023 dust emission explicitly.
    And change some existing aux_clm tests over to it (but not all).
    ekluzek committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    870588a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b669df6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2d889af View commit details
    Browse the repository at this point in the history
  7. REmove all of the settings of GLC_TWO_WAY_COUPLING set to FALSE since…

    … that's the default and it's not needed
    ekluzek committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e76b9d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    00537d1 View commit details
    Browse the repository at this point in the history
  2. Modify some of the comments based on code review, and simplify the Ma…

    …ssFracClayLeung2023 function
    ekluzek committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    f484425 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7e5a6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e83caa8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4daf924 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5007a1a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    63a2e73 View commit details
    Browse the repository at this point in the history
  8. Clarify the error message that the prigent streams file is required f…

    …or Leung 2023 dust emissions
    ekluzek committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    5a2c873 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    96d2de5 View commit details
    Browse the repository at this point in the history
  10. Add a unit test to check if dpfct_rock can be nan, currently fails as…

    … the nan handling inside of DustEmissions for Leung is not sufficient
    ekluzek committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    38c42ae View commit details
    Browse the repository at this point in the history
  11. Now passes the unit-test

    ekluzek committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    1fe61e6 View commit details
    Browse the repository at this point in the history
  12. Add obu to create_fv, and add test for obu of zero, and error handlin…

    …g for it (since downstream values can be corrupted if it's NaN or zero), also use shr_infnan_isnan for intrmtncy_fct
    ekluzek committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    1895cba View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. Configuration menu
    Copy the full SHA
    d426797 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f29bfb4 View commit details
    Browse the repository at this point in the history
  3. Add a test that low stabiility is constant dust emission output, chan…

    …ge tolerance to accomidate that, use asserts rather than endrun in the test code, increase fv and obu for one of the tests
    ekluzek committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    601b090 View commit details
    Browse the repository at this point in the history
  4. Change constants so they are more recognizable as floating point with…

    … a decimal, and remove subname in favor of giving line and filename with errmsg
    ekluzek committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    02b4f9a View commit details
    Browse the repository at this point in the history
  5. Update change files

    ekluzek committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    07a62b6 View commit details
    Browse the repository at this point in the history
  6. Update test number

    ekluzek committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    0d17de5 View commit details
    Browse the repository at this point in the history
  7. Update Change files

    ekluzek committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    39ecaf0 View commit details
    Browse the repository at this point in the history
  8. Change default back to Zender

    ekluzek committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    9b1ff24 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b45a7fa View commit details
    Browse the repository at this point in the history
  10. Update change files

    ekluzek committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    503c47f View commit details
    Browse the repository at this point in the history