Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic for adding psfc to aoflux_in #514

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fix logic for adding psfc to aoflux_in #514

merged 3 commits into from
Oct 23, 2024

Commits on Oct 17, 2024

  1. Ensure psfc is always allocated 

    This is needed to avoid a segmentation fault in the call to flux_atmocn
in SMS_Ld2.ne30pg3_t232.BMT1850.derecho_gnu.allactive-defaultio when
running with aoflux_grid=xgrid
    @billsacks
    billsacks committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    de94803 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. More correct fix to ensure psfc is allocated when needed 

    This is needed to avoid a segmentation fault in the call to flux_atmocn
in SMS_Ld2.ne30pg3_t232.BMT1850.derecho_gnu.allactive-defaultio when
running with aoflux_grid=xgrid.

I think that the previous fix wasn't correct when using xgrid, because I
think nothing is originally in fldbun_a in that case.
    @billsacks
    billsacks committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0bbdcd0 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Tweak conditional for setting psfc for ufs 

    Based on discussion in ESCOMP#514
    @billsacks
    billsacks committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d9255d5 View commit details
    Browse the repository at this point in the history