fix bug in ocn2glc_coupling and add blom #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billsacks
requested changes
Jul 11, 2024
| <!-- TODO: currently a NUOPC runseqence cannot be generated with the ATM_NCPL < OCN_NCPL - as is the case --> | ||
| <!-- with the POP2 C compset run sequence - for now will set these to be the same as MOM6 --> | ||
| <value compset="_DATM.*_DICE.*_BLOM">24</value> | ||
| <!-- NOTE: urrently a NUOPC runseqence cannot be generated with the ATM_NCPL < OCN_NCPL --> |
There was a problem hiding this comment.
Minor typo: urrently -> currently
Comment on lines
144
to
179
| <entry id="DMS_EMIS_OCN"> | ||
| <type>logical</type> | ||
| <default_value>FALSE</default_value> | ||
| <valid_values>TRUE,FALSE</valid_values> | ||
| <group>run_coupling</group> | ||
| <file>env_run.xml</file> | ||
| <desc>Activates DMS fluxes to be sent from ocn to atm </desc> | ||
| </entry> | ||
|
|
||
| <entry id="BRF_EMIS_OCN"> | ||
| <type>logical</type> | ||
| <default_value>FALSE</default_value> | ||
| <valid_values>TRUE,FALSE</valid_values> | ||
| <group>run_coupling</group> | ||
| <file>env_run.xml</file> | ||
| <desc>Activates Bromoform fluxes to be sent from ocn to atm </desc> | ||
| </entry> | ||
|
|
||
| <entry id="N2O_EMIS_OCN"> | ||
| <type>logical</type> | ||
| <default_value>FALSE</default_value> | ||
| <valid_values>TRUE,FALSE</valid_values> | ||
| <group>run_coupling</group> | ||
| <file>env_run.xml</file> | ||
| <desc>Activates N2O fluxes to be sent from ocn to atm </desc> | ||
| </entry> | ||
|
|
||
| <entry id="NH3_EMIS_OCN"> | ||
| <type>logical</type> | ||
| <default_value>FALSE</default_value> | ||
| <valid_values>TRUE,FALSE</valid_values> | ||
| <group>run_coupling</group> | ||
| <file>env_run.xml</file> | ||
| <desc>Activates NH3 fluxes to be sent from ocn to atm </desc> | ||
| </entry> | ||
|
|
There was a problem hiding this comment.
Are these only valid for BLOM currently? If so, I feel this should at least be documented. Ideally they would only be available for BLOM, or there would be an error check to ensure they aren't set for other models, but I suspect that's hard... if it's true that those would be hard to do, then I think it's fine to just add in the description something like "Only available with the BLOM ocean model" or something like that.
|
@billsacks - thanks so much for your review. I've addressed the issues you raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds blom as another ocean component in cime_config.
Specific notes
This adds blom as another ocean component in cime_config and also fixes the query of the logical variable for ocn2glc coupling in esmFldsExchange_cesm.F90.
Contributors other than yourself, if any: None
CMEPS Issues Fixed: No
Are changes expected to change answers? bfb
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed
Verified that ocn2glc coupling is working correctly with blom.