Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove negative runoff #471

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Remove negative runoff #471

merged 6 commits into from
Jun 26, 2024

Commits on Jun 21, 2024

  1. Remove negative runoff by downweighting positive runoff globally

    @billsacks
    billsacks committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ef749fa View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Removing negative runoff: Create a dedicated FieldBundle for mods 

    Avoid modifying fields in place so that the ROF import fields are truly
what came from ROF. So this removal of negative runoff will just appear
in the fields mapped to OCN.
    @billsacks
    billsacks committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f3761e0 View commit details
    Browse the repository at this point in the history

  2. Add a namelist flag controlling the removal of negative runoff

    @billsacks
    billsacks committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    8133bdc View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge remote-tracking branch 'origin/main' into remove_negative_runoff

    @billsacks
    billsacks committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    49b94d0 View commit details
    Browse the repository at this point in the history

  2. Remove negative runoff from new glc runoff fields

    @billsacks
    billsacks committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    516b8ef View commit details
    Browse the repository at this point in the history

  3. Don't try to remove negative runoff on an absent field 

    I'm not sure if this is necessary, but it seems like it could be in some
configurations, and it won't hurt to do this check.
    @billsacks
    billsacks committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4c5996e View commit details
    Browse the repository at this point in the history