avoid integer overflow by skipping mediator in restart loop #460
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JEdwards - what testing was done for this? Can you please run a few tests to demonstrate that this fix does not adversely effect other configurations. |
mvertens
approved these changes
May 17, 2024
slevis-lmwg
added a commit
to slevis-lmwg/ctsm
that referenced
this pull request
May 17, 2024
|
We have a long lists of tests that fail in our CTSM PR ESCOMP/CTSM#2539. It would be good to have this come in as a tag so we can show those tests PASS. What testing needs to be done for this to come in? Maybe the aux_cmeps and aux_clm test lists in a CESM checkout? |
slevis-lmwg
added a commit
to slevis-lmwg/ctsm
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This loop in med_phases_restart_mod.F90 was causing integer overflow because the med component should not be included. This was only happening with the nag compiler in debug mode and would not normally be a problem since integer overflows are ignored (except by nag in debug mode) and the resulting values were never used.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing