Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renames ww3dev to ww3 #457

Merged
merged 1 commit into from
May 22, 2024
Merged

renames ww3dev to ww3 #457

merged 1 commit into from
May 22, 2024

Conversation

jedwards4b
Copy link
Collaborator

Description of changes

One line change so that ww3dev can be renamed ww3

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

@jedwards4b jedwards4b requested a review from mvertens May 16, 2024 17:06
@jedwards4b jedwards4b self-assigned this May 16, 2024
@@ -127,7 +127,7 @@ def _create_drv_namelists(case, infile, confdir, nmlgen, files):
elif case.get_value("RUN_TYPE") == "branch":
config["run_type"] = "branch"

config['wav_ice_coupling'] = config['COMP_WAV'] == 'ww3dev' and config['COMP_ICE'] == 'cice'
config['wav_ice_coupling'] = 'ww3' in config['COMP_WAV'] and config['COMP_ICE'] == 'cice'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please make this backwards compatible with the previous version by adding
config['COMP_WAV'] == 'ww3dev' or config['COMP_WAV'] == 'ww3'
That way we can use this in NorESM for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that. ww3 is a substring of ww3dev and so 'ww3' in config['COMP_WAV'] works for both.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I did not catch that. Looks good.

@jedwards4b jedwards4b requested a review from mvertens May 16, 2024 20:05
@jedwards4b jedwards4b merged commit 95d6f69 into ESCOMP:main May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants