Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove this unused variable #417

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

jedwards4b
Copy link
Collaborator

Description of changes

Remove unused ESMF_LOGFILE_KIND variable.

Specific notes

This variable is not used, control for esmf logfiles is through variable
CREATE_ESMF_PET_FILES
Contributors other than yourself, if any: Ufuk

CMEPS Issues Fixed #416

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) bfbSMS.f19_g17.X.frontera_intel

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
SMS.f19_g17.X.frontera_intel

@jedwards4b jedwards4b self-assigned this Oct 23, 2023
Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks for cleaning those.

@jedwards4b jedwards4b merged commit 914957b into ESCOMP:main Nov 6, 2023
2 checks passed
@jedwards4b jedwards4b deleted the remove_esmf_logfile_kind branch November 6, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing ESMF_LOGFILE_KIND definition in the namelist
2 participants