Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code to use HPE SMARTREDIS #213

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jedwards4b
Copy link
Collaborator

@jedwards4b jedwards4b commented Jul 16, 2021

Description of changes

Adds an interface to the HPE SmartSim database. Currently only tested on casper with gnu compiler.
Adds a test mod for testing with smartsim.
Requires CESM_share ESCOMP/CESM_share#5

Provides new xml boolean variables USE_SMARTSIM and CREATE_SMARTSIM_CLUSTER to indicate that this mode should be invoked.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes New variables in drv_in namelist use_smartredis, create_smartsim_cluster
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:

@jedwards4b jedwards4b marked this pull request as ready for review August 16, 2021 16:58
@mvertens
Copy link
Collaborator

@jedwards4b - I have asked that output is written to the mediator or driver log file rather than the PET log file to document smartsim usage. Can you also summarize the two new xml variables in the description of the PR.

end if
call mpi_bcast (use_smartredis, 1, MPI_LOGICAL, 0, COMP_COMM, ier)
call mpi_bcast (create_smartsim_cluster, 1, MPI_LOGICAL, 0, COMP_COMM, ier)
if (use_smartredis) then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write to the cmeps logunit and not the PET. It would be good to have this in the mediator log file. Or does this belong in the driver write file?

@jedwards4b
Copy link
Collaborator Author

jedwards4b commented Sep 26, 2021 via email

@mvertens
Copy link
Collaborator

@jedwards4b - what is the status of this PR?

@jedwards4b jedwards4b marked this pull request as draft March 31, 2022 13:58
@jedwards4b
Copy link
Collaborator Author

I have a meeting next week with the smartsim developers, they tell me that they have a new method
that will require a different approach from cime. I'll amend or close and replace this at that time.

mvertens pushed a commit to mvertens/CMEPS that referenced this pull request Jan 30, 2023
@mvertens mvertens mentioned this pull request Jan 30, 2023
1 task
jedwards4b added a commit that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants