Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nuopc_shr_methods.F90 for UFS #298

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

jedwards4b
Copy link
Contributor

Description of changes

Copy of file nuopc_shr_methods from https://github.com/ESCOMP/CESM_share needed by UFS

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial):

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

Hashes used for testing:

@jedwards4b jedwards4b self-assigned this Aug 21, 2024
Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedwards4b This looks good but could you remind me why this is needed now. Are those methods moved to the central place for CESM? BTW, let me test this with UFS WM to be sure it is fine.

@jedwards4b
Copy link
Contributor Author

@DeniseWorthen has tested the cmeps that depends on this.

@uturuncoglu
Copy link
Collaborator

@jedwards4b Okay. That is great. Thanks.

@jedwards4b jedwards4b merged commit 483a45a into ESCOMP:main Aug 22, 2024
1 check passed
@jedwards4b jedwards4b deleted the add/nuopc_shr_methods.F90 branch August 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants