Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dglc component with noevolve mode #268

Merged
merged 32 commits into from
Apr 1, 2024

Conversation

mvertens
Copy link
Collaborator

@mvertens mvertens commented Mar 29, 2024

Description of changes

This PR adds a new data glc component with a single noevolve mode.

Specific notes

The new dglc is aimed at replacing the use of CISM in noevolve mode.

Contributors other than yourself, if any: @billsacks @jedwards4b

CDEPS Issues Fixed: None

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial):

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
The following tests were carried out successfully on derecho:
./create_test --xml-category aux_cdeps --xml-machine derecho --compare cdeps1.0.28 --generate cdeps1.0.30

Hashes used for testing:
Used cesm2_3_alpha17a/ plus the hashes listed above in the summary of the associated PRs.

mvertens and others added 25 commits April 26, 2023 14:01
new passing of 10m wind explicitly to ww3 -
@mvertens mvertens added the enhancement New feature or request label Mar 29, 2024
Data Land-Ice (DGLC)
=================

DGLC is normally used as a substitute for CESM/CISM running in NOEVOLVE mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be written in a more model agnostic way? Will all users of dglc be familiar with cesm and/or cism?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedwards4b - no one other than CESM and NorESM uses a land-ice component right now - and the whole point of the dglc was to remove the need to run with CISM running in noevolve mode. @billsacks - can you think of another way to state this? I can't.

@mvertens mvertens requested a review from billsacks March 30, 2024 09:14
gold2718 added a commit to NorESMhub/cime that referenced this pull request Apr 1, 2024
merge to cime6.0.232

This PR merges the NorESMHub cime fork to cime6.0.232 and is needed to have the new dglc component be able to be run out of system tests.

Test suite: Testing was done on derecho - see ESCOMP/CDEPS#268

Fixes: None

User interface changes?: None

Update gh-pages html (Y/N)?: N
Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on discussion with @mvertens . Thank you very much for your amazing work on this @mvertens !

@jedwards4b jedwards4b merged commit df7ccea into ESCOMP:main Apr 1, 2024
1 check passed
gold2718 added a commit to NorESMhub/CDEPS that referenced this pull request Apr 25, 2024
Update to cdeps1.0.32 from ESCOMP

- Add a new DGLC component (see ESCOMP#268)

Contributors other than yourself, if any: None
CDEPS Issues Fixed: None

Are there dependencies on other component PRs (if so list): Yes
See documentation in ESCOMP#268
Are changes expected to change answers: No, verified as BFB
Any User Interface Changes: only for DGLC

Testing performed
Ran prealpha_noresm test suite along with aux_cdeps_noresm successfully

Hashes used for testing:
Externals in what will be noresm2_5_alpha02
@ekluzek ekluzek mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants