Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to turn off soil erosion in CAM for dust emissions #748

Closed
wants to merge 3 commits into from

Conversation

fvitt
Copy link

@fvitt fvitt commented Feb 3, 2023

closes #651
closes #141

	modified:   bld/namelist_files/namelist_definition.xml
	modified:   src/chemistry/modal_aero/dust_model.F90
        modified:   src/chemistry/bulk_aero/dust_model.F90
        modified:   src/chemistry/modal_aero/dust_model.F90
@fvitt fvitt self-assigned this Feb 3, 2023
@fvitt fvitt added the enhancement New feature or request label Feb 3, 2023
@fvitt fvitt added this to the CAM6.5 milestone Feb 3, 2023
@fvitt
Copy link
Author

fvitt commented Feb 3, 2023

@ekluzek @dmleung This is the PR for soil erosion switch in CAM. Please review. Thanks.

Copy link

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default for soil_erod_active should be TRUE, until we bring the changes into the CTSM side, when it'll be FALSE. Looks like this is only documented wrong in the namelist definition file.

<entry id="soil_erod_active" type="logical" category="cam_chem"
group="dust_nl" valid_values="" >
Switch to turn on/off soil erodibility for dust emissions in CAM.
Default: FALSE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should be TRUE, until after this is in CTSM and always on in there.

@dmleung
Copy link

dmleung commented Mar 21, 2023

ESCOMP/CTSM#1967 now has the corresponding changes in CTSM.

@ekluzek
Copy link

ekluzek commented Apr 3, 2023

This also relates to #778.

This will also update both CMEPS and CTSM, so will happen after those tags are made.

The CMEPS issue is: ESCOMP/CMEPS#353

@ekluzek
Copy link

ekluzek commented Jul 31, 2023

@ekluzek
Copy link

ekluzek commented Jul 31, 2023

When we are closer to having this all together and working, we should validate that the dust emission is similar when in CTSM as in CAM by comparing results between the two. We expect answers to be different by greater than roundoff, but they should be qualitatively similar.

@ekluzek
Copy link

ekluzek commented Jul 11, 2024

@fvitt note that the CMEPS PR has been tagged as cmeps0.14.73. The PR to use that in CTSM is ESCOMP/CTSM#2545. Once the CTSM tag is in place this one could come in.

@ekluzek
Copy link

ekluzek commented Jul 23, 2024

The latest CAM (cam6_4_015) has already updated beyond the needed CMEPS tag (to cmeps1.0.2), so this can start to be changed to use the namelist items in the drv_flds_in for dust_emis_inparm. If this PR is hard to update, it could also be restarted from the latest CAM tag.

@fvitt
Copy link
Author

fvitt commented Jul 24, 2024

@ekluzek Thanks for the comments and pointing me to this PR. I will probably start a new branch and PR this is quite old...

@fvitt fvitt closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants