add option for disabling Matomo cookies #314
Conversation
In RSQKit we want to disable Matomo cookies for now. This makes the site more easily GDPR compliant (without cookie wall). It only takes a single added line of JS, which this commit adds.
The head.html file was copied from the current ETT version (3.2.0). Hopefully, ETT will adopt the PR to disable Matomo cookies (ELIXIR-Belgium/elixir-toolkit-theme#314). When they do, the head.html file in this repo can be removed again and we can simply configure the disabling of Matomo cookies via _config.yml. This commit also pins the ETT version to 3.2.0 to make sure we update it manually later.
| @@ -29,6 +29,8 @@ matomo: | |||
| # Matomo domain where Matomo is running | |||
| matomo_id: | |||
| # Integer indicating the Matomo Website ID | |||
| matomo_cookies: false | |||
There was a problem hiding this comment.
I personally would leave the default behavior to the current behavior, which is matomo_cookies: true or not having this setting at all. Please also update https://elixir-belgium.github.io/elixir-toolkit-theme/configuring_theme
There was a problem hiding this comment.
Makes sense!
I wasn't sure what would happen if existing sites start using this functionality without adding matomo_cookies to their _config.yml. I.e. what is the default value of an undefined variable? What I gathered from my Googlings was that an empty value would be truthy (I read somewhere that only false and NIL are falsy), so then when users update ETT without adding matomo_cookies it would indeed be evaluated as true and hence the unless site.matomo_cookies clause would not trigger.
But it's very well possible I am mistaken! In any case, I will change the default value.
There was a problem hiding this comment.
Or is NIL actually what a non-defined value is? In that case I now understand your second more explicit if false suggestion! :D
_includes/head.html
Outdated
| @@ -124,6 +124,9 @@ | |||
| <script> | |||
| var _paq = window._paq = window._paq || []; | |||
| /* tracker methods like "setCustomDimension" should be called before "trackPageView" */ | |||
| {%- unless site.matomo_cookies %} | |||
There was a problem hiding this comment.
| {%- unless site.matomo_cookies %} | |
| {%- if site.matomo_cookies == false %} |
I prefer it reverted. So if people don't want cookies, they have to explicitly say false.
There was a problem hiding this comment.
I think these two statements are equivalent, no? But perhaps the more explicit if version is better indeed.
In RSQKit we want to disable Matomo cookies for now. This makes the site more easily GDPR compliant (without cookie wall). It only takes a single added line of JS, which this commit adds.