Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved contributors tiles and carousel fix #308

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Improved contributors tiles and carousel fix #308

merged 1 commit into from
Dec 17, 2024

Conversation

bedroesb
Copy link
Member

  • Some code refactoring
  • The filtering based on role was not working well, this should be fixed now
  • Also handling of no contributors are improved.

This will close #307

@bedroesb
Copy link
Member Author

@anenadic Hope this fixes your bug!

@anenadic
Copy link
Contributor

Thank you - may need to come back to this next week and check. And yes, there were some issue about role filtering - thank you for fixing that as well @bedroesb.

@bedroesb
Copy link
Member Author

I will wait for the new release until this one is approved and merged, this is an obvious bug!

@bedroesb
Copy link
Member Author

@anenadic I just realize that I merged the PR to prepare for a new release to soon, and now the new version is in the README. If ok for you would like to merge this one, and create a new release today.

@anenadic
Copy link
Contributor

All good here - thank you.

@bedroesb bedroesb merged commit 14c7bbe into main Dec 17, 2024
2 checks passed
@bedroesb bedroesb deleted the contr-fix branch December 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hanging </div> visible when no contributors found on Editorial Board page
2 participants