Use shell: bash when installing wheels in CIs #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed an issue with installing compiled wheels in my test CIs in another project.
Apparently, pip ignores the --file-links argument if it finds a suitable wheel with the same name on PyPI. That means that it will ignore installing from the existing local wheel, and instead download the one on PyPI and install that one. This defeats the purpose of the test, as we are not testing the correct wheel!
This was solved by adding the -* wildcard fix like so package_name-* to the command. However, that fails in Powershell (on Windows). Thus, forcing the command to run with bash works for all operating systems.