Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disqus Comment Widget Replacement #2613

Merged
merged 10 commits into from
Jun 23, 2020
Merged

Disqus Comment Widget Replacement #2613

merged 10 commits into from
Jun 23, 2020

Commits on Jun 17, 2020

  1. add disqus object to social widgets json

    @ablanathtanalba
    ablanathtanalba committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    e6a7e75 View commit details
    Browse the repository at this point in the history

  2. allow wildcard widget domain unblocking with regex

    @ablanathtanalba
    ablanathtanalba committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f3b2411 View commit details
    Browse the repository at this point in the history

  3. correct typo on regex assignment

    @ablanathtanalba
    ablanathtanalba committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    6fd2f33 View commit details
    Browse the repository at this point in the history

  4. add domain wildcard support for getWidgetList

    @ablanathtanalba
    ablanathtanalba committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    3e5fcb7 View commit details
    Browse the repository at this point in the history

  5. simplified some pattern matching in allowedOnTab method

    @ablanathtanalba
    ablanathtanalba committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    d995690 View commit details
    Browse the repository at this point in the history

  6. add wildcard to disqus json blob, add support for handling wildcard i… 

    …n getWidgetList
    @ablanathtanalba
    ablanathtanalba committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    9246104 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Remove unneeded/redundant Disqus widget domains

    @ghostwords
    ghostwords committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    e91262b View commit details
    Browse the repository at this point in the history

  2. Simplify wildcard allowed widget domains 

    No need for regexes yet.
    @ghostwords
    ghostwords committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    20deb05 View commit details
    Browse the repository at this point in the history

  3. Fix nits in replacement domain matching 

    - If there are multiple wildcard domain matches,
  make sure all of them were blocked

- If we have a wildcard domain that didn't match our criteria,
  don't keep going onto non-wildcard domain logic
    @ghostwords
    ghostwords committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    26a43bc View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Fix wildcard domains for dynamic widget elements 

    Domain matching for widget elements created after initial page load
needed to be updated to support wildcards.
    @ghostwords
    ghostwords committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    799e4c2 View commit details
    Browse the repository at this point in the history