Add replacement widget for Google reCAPTCHA #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwords
added
the
widgets
ghostwords
force-pushed
the
recaptcha-replacement-widget
branch
from
01d4e34
to
9f37741
Compare
ghostwords
force-pushed
the
recaptcha-replacement-widget
branch
from
9f37741
to
756371a
Compare
Type 0 replacements do not send unblockWidget messages, and so do not make use of unblockDomains.
ghostwords
force-pushed
the
recaptcha-replacement-widget
branch
from
756371a
to
a802335
Compare
This happens when the (reCAPTCHA) script is inserted dynamically.
ghostwords
force-pushed
the
recaptcha-replacement-widget
branch
from
c4a5697
to
615d520
Compare
To facilitate testing.
For dynamically-inserted widgets (created after initial page load). This probably explains #2539 (comment)
These exercise type 3 widgets only for now.
ghostwords
force-pushed
the
recaptcha-replacement-widget
branch
from
4a2fafc
to
13db850
Compare
|
Nice, just saw those updates modernizing the loops 👍 |
While the container div is an inline part of the page, the div is populated by a third-party script. If we look for the output before the script finished loading and executing, it looks like the widget failed to load, but in fact we merely checked too quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1542.
Should be rebased on #2484 to avoid replacing reCAPTCHA when it's only been cookieblocked. (Right now we ask, "would we blockgoogle.com?" and the answer is yes, but what we want to ask is, "did we blockgoogle.com?" (as opposed towww.google.com)Parts borrowed from #2271. Should redo that PR from master after this is merged.
www.google.comreCAPTCHA examples (currently yellowlisted, so you have to tell your Privacy Badger to blockwww.google.comfirst):google.comreCAPTCHA examples:Dynamically inserted (024fffc) examples: