-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "guildwars2.com" to yellowlist #2115
Conversation
I think you want to add the domain to the yellowlist, not the multi-domain first-parties list. |
Could you provide the debugging information requested in https://github.com/EFForg/privacybadger/blob/1cac5ba752517802d0596645c464ffd55a60c9d0/.github/ISSUE_TEMPLATE/broken-site-report.md? |
We might want to add all of Error report counts by page domain and exact blocked "guildwars" subdomain:
Error report counts by date and exact blocked "guildwars" subdomain:
|
Possibly related to #1545? |
Ah, yes. I updated the PR to use the yellowlist instead.
Sadly not, I don't use PrivacyBadger, I just get reports of my page (gw2efficiency.com) not working fairly frequently, so I thought I'd fix the issue here. :)
Ah, yes. I added the TLD. Here is what the specific domains do, in case that's interesting:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thank you! We'll get this released next week, perhaps on Tuesday.
Privacybadger is blocking access to
api.guildwars2.com
which is the official public API for the MMORPG Guild Wars 2. It can only be used to read personal data off an account if the user previously generated and provided a valid API key (see "Authentication" section at the bottom), which makes this opt-in.(Probably?) since all sites making use of that API are hosted on different domains, and most of the sites access the API from the client side, Privacybadger blocks the access to this API, regularly causing questions like this or this.