Fix DNT header test #2047
Merged
Fix DNT header test #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix JS errors when restoring a browser session. Also lets tests check badger.INITIALIZED to see if listeners are ready.
Unnecesary now that we wait to initialize listeners until `badger` is ready.
This was referenced Jun 3, 2018
bcyphers
approved these changes
Sep 6, 2018
Conflicts: src/js/background.js tests/selenium/dnt_test.py
ghostwords
added a commit
that referenced
this pull request
Sep 7, 2018
Fix sporadic DNT header test failures by having Badger's INITIALIZED flag account for listener initialization and then checking INITIALIZED before performing the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures like https://travis-ci.org/EFForg/privacybadger/jobs/386391284#L562 by waiting until Badger reports listeners are ready.
Fixes #1240.
What about #1845: better, worse, or no change?