Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websimages.com and webs.com to yellowlist #1663

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Add websimages.com and webs.com to yellowlist #1663

merged 1 commit into from
Sep 25, 2017

Conversation

terrorist96
Copy link
Contributor

@terrorist96 terrorist96 commented Sep 13, 2017 •
edited
Loading

Fixes #1244
Fixes #1140
Also reordered some domains to alphabetical order

@terrorist96
Add websimages.com and webs.com to yellowlist
55804f6 
Fixes #1244 and #1140.
Also reordered some domains to alphabetical order
@ghostwords ghostwords self-requested a review September 13, 2017 17:51
@ghostwords ghostwords added the yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage label Sep 13, 2017
@ghostwords
Copy link
Member

ghostwords commented Sep 14, 2017 •
edited
Loading

Looks like websimages.com only sets __cfduid (which we already ignore) and session cookies. Should we just ignore session cookies (#1545)?

@ghostwords
Copy link
Member

ghostwords commented Sep 14, 2017 •
edited
Loading

I don't see any webs.com or websimages.com reports in error reports. It doesn't mean we don't have any since we have bug (bugs?) that result in empty or partial reporting of which domains were blocked on the page, but still, having no matches suggests an uncommon problem.

@terrorist96
Copy link
Contributor Author

Want me to submit reports? 🤣 Uncommon problems should still get fixed, should they not?

@ghostwords
Copy link
Member

Heh, that's not necessary. True, I'm just trying to figure out how to triage more effectively.

ghostwords
ghostwords approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@ghostwords ghostwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good call on reordering.

@ghostwords ghostwords merged commit 1c63318 into EFForg:master Sep 25, 2017
@terrorist96 terrorist96 deleted the patch-1 branch September 25, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostwords ghostwords ghostwords approved these changes

Assignees
No one assigned
Labels
yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrorist96 @ghostwords