Move contentscripts into their own directory. #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostwords
requested changes
Jun 9, 2017
There was a problem hiding this comment.
Good idea, but you should check for references outside of manifest.json.
For example, release-utils/make-signed-xpi.sh needs to be updated or we run into the issue behind #1053 again.
ghostwords
added a commit
that referenced
this pull request
Jun 12, 2017
Move contentscripts into their own directory. Conflicts: src/manifest.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
src/js/directory was getting a little cluttered so I moved the content scripts into their own zone.