-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no Trackers detected in specified startup page (aka home page) in Firefox #1845
Comments
I think this is what #1240 entails for users. Privacy Badger takes a bit to initialize; the browser doesn't wait for Privacy Badger to initialize on browser start; if the browser starts opening pages right away (whether the homepage or previously open pages), it is likely Privacy Badger will miss at least some of what happens on those pages. We could try speeding up Privacy Badger's initialization although we will probably always have some amount of lag before Privacy Badger is ready. We could also update Privacy Badger's popup to somehow indicate that Privacy Badger wasn't available from the start of this page's loading, so this is only a partial report. |
I totally agree with you
I think this would be userfriendly to show info about the problem and maybe if Privacy Badger itself is not able to force a reload (e.g. if ffox is not alowing that) then the popup could include some sort of "please reload this tab" or show a reload button to assist. But this is maybe far away of a solution to handle this easily for users |
Related Bugzilla issue: "Allow some addon functionality to load prior to any content loading". |
So it seems that instead of having listeners get initialized without regard for storage initialization (which was the case before fde33ef), or having listeners get initialized after storage is initialized (fde33ef), which fixed the JS errors/bad request handling on browser startup but made the listeners "non-persistent" in Firefox and so led to missing (probably more) requests entirely on browser startup, we should explore initializing the listeners during initial synchronous execution (not in a callback) and either gracefully handle calling storage when it isn't yet ready (we miss processing some requests but maybe not as many as we miss now, at least in Firefox), or use async/Promises (would catch all requests but only in Firefox? what will happen in Chrome?). Relevant discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1501159 Edit: |
Hey there,
maybe this is a problem or intended functionality?
If I set a single webpage as my Firefox "home page" to load it directly after start up PB is showing a green Status with 0. Looking into PB it's telling me "Hurray, no Trackers detected" and there is no list of domains in PB. Looking at my startup page I see every single ad - nothing is handled or blocked even if I manually specified some domains to be blocked.
Do I start FFox with an empty page and then visit only the page I set as startup page PB is turning red seeing a lot of domains to block. Opening PB I can see all settings of PB itself and manualy changed by me. A lot of the ads are blocked.
I do not see why there snhould be a difference between the home page and directly opening that page . It feels like "home page" is completely whitelisted.
Recognized in Firefox 58, I think it happend to FFox 57.x , too.
PB Version 2018.1.22
Best regards
Alex.
The text was updated successfully, but these errors were encountered: