Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore canvas fingerprinting detection to Firefox #1158

Closed
ghostwords opened this issue Jan 26, 2017 · 6 comments · Fixed by #1678
Closed

Restore canvas fingerprinting detection to Firefox #1158

ghostwords opened this issue Jan 26, 2017 · 6 comments · Fixed by #1678
Labels
Firefox heuristic Badger's core learning-what-to-block functionality important

Comments

@ghostwords
Copy link
Member

This is the followup to #1053. We should make canvas fingerprinting detection cross-browser; src/fingerprinting.js currently relies on some Chrome-specific APIs.

@fedde-s
Copy link

fedde-s commented Jan 26, 2017

Are there short-term plans to release a bugfix update that disables the functionality on non-V8 browsers to make them usable again until the code is improved, as you seem to suggest in the closed pull request you linked? I believe it is currently making various web applications unusable while PB is running, also being mentioned in #1157 and several closed issues about previous occurrences of the same breakage.

@ghostwords
Copy link
Member Author

ghostwords commented Jan 26, 2017

Yes, absolutely, we should do that on Firefox ASAP. I would if I could.

Update: Should be fixed with Privacy Badger version 2017.1.26.1, released a few minutes ago.

@ghostwords ghostwords added heuristic Badger's core learning-what-to-block functionality important labels Mar 15, 2017
@ghostwords
Copy link
Member Author

Should also take care of #1268 at the same time.

@cowlicks
Copy link
Contributor

In #1505 I have a cross-platform way to get the stacktrace and origin associated with some Javascript execution. This should fix this issue. (link):

function scriptOrigin() {
  try {
    yo = dog;  // eslint-disable-line
  } catch (e) {
    return e.stack.split('\n')[3].split('/')[2];
  }
}

@ghostwords
Copy link
Member Author

ghostwords commented Jul 20, 2017

@ghostwords
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firefox heuristic Badger's core learning-what-to-block functionality important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants