Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/analysis supression #368

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Hotfix/analysis supression #368

merged 2 commits into from
Oct 14, 2024

Conversation

MGS-sails
Copy link
Contributor

No description provided.

@SandyRogers
Copy link
Member

Just to be sure I understand/remember right - the idea here is that through study -> analysis suppression propagation, we should no longer need to check the study suppression state at render time? Because the suppression propagation will have explicitly suppressed a study's analyses, right?

@MGS-sails
Copy link
Contributor Author

@SandyRogers in response to your comment:
Initially there was an issue with the file downloads for MGYA00636765 were being returned by this API https://www.ebi.ac.uk/metagenomics/api/v1/analyses/MGYA00636765?include=downloads.
This should not have been the case because the parent study had been suppressed. So we pushed a temporary fix to filter it out of the API.

In line with your observation above,
after we run the supression job, it should no longer be necessary to rely on the filter we added.

@SandyRogers
Copy link
Member

@SandyRogers in response to your comment: Initially there was an issue with the file downloads for MGYA00636765 were being returned by this API https://www.ebi.ac.uk/metagenomics/api/v1/analyses/MGYA00636765?include=downloads. This should not have been the case because the parent study had been suppressed. So we pushed a temporary fix to filter it out of the API.

In line with your observation above, after we run the supression job, it should no longer be necessary to rely on the filter we added.

Perfect - thank you! Happy to merge

@MGS-sails MGS-sails merged commit 2568ea2 into develop Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants