Fixes for a few bugs I encountered while testing the command #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Assembly and Run based jobs (both). Remove the public check, we only submit public data to the exchange. Normalize argument names in the MGX wrapper. Added some docstrings
The MGX API returns a json with the error message, which is useful for debugging.
SandyRogers
approved these changes
Feb 16, 2024
| return analysis_registry_id, metadata_match | ||
|
|
||
| data = response.json() | ||
| datasets = data.get("datasets", []) | ||
|
|
||
| # The API will return an emtpy datasets array if it can find the accession | ||
| if not len(datasets): | ||
| logging.info(f"{source_id} does not exist in ME") | ||
| logging.info(f"{mgya} does not exist in ME") | ||
| return analysis_registry_id, metadata_match | ||
|
|
||
| sourceIDs = [item.get("sourceID") for item in datasets] |
There was a problem hiding this comment.
Can it be:
try:
found_record = next(item for item in datasets if item.get("sourceID") == mgya)
except StopIteration:
...or similar?
There was a problem hiding this comment.
Yeah, it could be. I think method needs some improvements and some more unit tests. I'll create a JIRA ticket improve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.