update cube_to_target #6463
Merged
update cube_to_target #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
On which machines that we support is it supposed to run, if any? |
|
@oksanaguba I don't know of any requirement to have this running on a supported machine. Someone created a script to allow regular testing, but I don't think we actually run tests. The idea here was to clean it up and make sure it works on Perlmutter and Chrysalis, which seem to be the machines that most people use most of the time. We can modify this to support other machines as the use cases arise. |
|
@whannah1 thanks. so this needs to be tested on PM and chrysalis. did you test on either or should i? |
|
I verified that it builds and runs on both Perlmutter and Chrysalis. |
oksanaguba
added a commit
that referenced
this pull request
Jul 22, 2024
Clean up and simplify the Makefile for the cube_to_target topography generation tool. [BFB]
oksanaguba
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up and simplify the Makefile for the cube_to_target topography generation tool.
[BFB]