Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segments): delete functionality for segments #1651

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jskelin
Copy link
Contributor

@jskelin jskelin commented Dec 13, 2024

With these changes, delete functionality for segments is supported. To declare segment config for delete, in delete.yaml file add an entry like this for indirect reference:

- type: segment
  project: my-project
  id: monaco-config-id

or for direct reference like next:

- type: segment
  objectId: origin-object-ID

@jskelin jskelin requested a review from a team as a code owner December 13, 2024 14:25
@jskelin jskelin self-assigned this Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Unit Test Results

1 960 tests  +19   1 959 ✅ +19   54s ⏱️ ±0s
  135 suites + 1       1 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 5fc72b5. ± Comparison against base commit 74698e1.

This pull request removes 2 and adds 21 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_delete_them_all
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/Segment_should_fail_if_FF_MONACO_FEAT_SEGMENTSis_not_set
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/FF_is_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_no_delete,_no_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case_with_FF_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDelete
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDelete/config_declared_via_coordinate_doesn't_exists_-_no_error_(wanted_state_achieved)
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDelete/config_declared_via_coordinate_failed_to_get_externalId_-_an_error
…

♻️ This comment has been updated with latest results.

@jskelin jskelin added the release-notes This feature/fix should be mentioned in release notes label Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

E2E Test Results

    4 files  ± 0    272 suites  +2   19m 3s ⏱️ - 5m 33s
2 079 tests +19  2 077 ✅ +19  2 💤 ±0  0 ❌ ±0 
2 230 runs  +32  2 228 ✅ +32  2 💤 ±0  0 ❌ ±0 

Results for commit 5fc72b5. ± Comparison against base commit 74698e1.

This pull request removes 2 and adds 21 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_delete_them_all
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/Segment_should_fail_if_FF_MONACO_FEAT_SEGMENTSis_not_set
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/FF_is_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_no_delete,_no_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case_with_FF_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDelete
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDelete/config_declared_via_coordinate_doesn't_exists_-_no_error_(wanted_state_achieved)
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDelete/config_declared_via_coordinate_failed_to_get_externalId_-_an_error
…

♻️ This comment has been updated with latest results.

@jskelin jskelin changed the title Delete functionality for segments feat(segments): delete functionality for segments Dec 16, 2024
@jskelin jskelin force-pushed the feat/GFF/delete branch 2 times, most recently from b665f42 to 7fda2be Compare December 19, 2024 15:24
Copy link

@jskelin jskelin added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes This feature/fix should be mentioned in release notes run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant