Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Settings API with OAuth credentials #1636

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomazpu
Copy link
Contributor

@tomazpu tomazpu commented Nov 22, 2024

What this PR does / Why we need it:

This PR removes the validation check for Settings API in download and deploy to fail if Token is not set. This allows to use OAuth credentials with Settings API.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@tomazpu tomazpu requested a review from a team as a code owner November 22, 2024 14:08
Copy link

github-actions bot commented Nov 22, 2024

Unit Test Results

1 893 tests  +2   1 892 ✅ +2   54s ⏱️ ±0s
  133 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 5e3a60c. ± Comparison against base commit 3ca846a.

♻️ This comment has been updated with latest results.

@tomazpu tomazpu self-assigned this Nov 22, 2024
@tomazpu tomazpu added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

E2E Test Results

    4 files   -   1    268 suites   - 133   26m 19s ⏱️ - 43m 24s
2 011 tests ±  0  2 009 ✅ ±  0  2 💤 ±0  0 ❌ ±0 
2 126 runs   - 115  2 124 ✅  - 115  2 💤 ±0  0 ❌ ±0 

Results for commit 5e3a60c. ± Comparison against base commit 3ca846a.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_ValidateAuthenticationWithProjectConfigs/OAuth_manifest_with_settings_api
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/download ‑ TestDownloadConfigs_OnlySettings

♻️ This comment has been updated with latest results.

@tomazpu tomazpu added run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Nov 22, 2024
@arthurpitman arthurpitman self-requested a review November 22, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants