Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings api to use ResourceContext over ModificationInfo #1633

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update settings api to use ResourceContext over ModificationInfo #1633

wants to merge 4 commits into from

Commits on Nov 21, 2024

  1. refactor: refactor client code to depend on DownloadSettingObject m… 

    …ethods, instead of `ModificationInfo` directly, to allow for a fallback implementation between `ResourceContext` and `ModificationInfo`
    @tomazpu
    tomazpu committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2af6ac3 View commit details
    Browse the repository at this point in the history

  2. feat: implement DownloadSettingsObject methods

    @tomazpu
    tomazpu committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1f66165 View commit details
    Browse the repository at this point in the history

  3. chore: Add unit test to test modificationInfo returns same results as… 

    … resourceContext
    @tomazpu
    tomazpu committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    45340bd View commit details
    Browse the repository at this point in the history

  4. chore: update branch after rebase

    @tomazpu
    tomazpu committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7442a1e View commit details
    Browse the repository at this point in the history