Consider skip parameter during preloading of configs on caching #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skip parameters set to true
tomazpu
added
run-e2e-test
E2E Test Results 4 files - 1 270 suites - 134 44m 14s ⏱️ - 29m 10s Results for commit 82890e7. ± Comparison against base commit 7ec89f8. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jskelin
previously approved these changes
Nov 7, 2024
| @@ -359,3 +359,50 @@ func Test_ScopedConfigsAreNotCached(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func Test_gatherPreloadConfigTypeEntries_WithSkipParam(t *testing.T) { | |||
There was a problem hiding this comment.
What is your opinion if we divide this test into 3 subtests:
- skip = true
- skip = false
- skip is not defined (aka default value)
Is it going to be more readable?
Laubi
force-pushed
the
fix/preload/caching-issue
branch
from
82890e7
to
218316e
Compare
Laubi
previously approved these changes
Nov 7, 2024
Laubi
approved these changes
Nov 7, 2024
tomazpu
force-pushed
the
fix/preload/caching-issue
branch
from
4777f90
to
bfe13fd
Compare
|
Laubi
approved these changes
Nov 7, 2024
tomazpu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Skip caching for configs of type classic and setting that have the skip parameter set to true. As the configs won't be deployed there is no need to chache them. With this being skipped, we also prevent performance degradation compared to the previous version.
Special notes for your reviewer:
Does this PR introduce a user-facing change?