Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/use retry logic from core library #1561

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arthurpitman
Copy link
Contributor

What this PR does / Why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@arthurpitman arthurpitman added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

Unit Test Results

    1 files  ± 0    133 suites  ±0   1m 54s ⏱️ - 1m 15s
1 835 tests  - 35  1 822 ✅  - 47  1 💤 ±0  12 ❌ +12 
1 834 runs   - 36  1 821 ✅  - 48  1 💤 ±0  12 ❌ +12 

For more details on these failures, see this check.

Results for commit 67f9234. ± Comparison against base commit fc9f24c.

This pull request removes 36 and adds 1 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestDeleteSettings
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestDeleteSettings/Delete_Settings_-_object_ID_is_passed
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestDeleteSettings/Delete_Settings_-_server_response_!=_2xx
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestDeleteSettings/Delete_Settings_-_server_response_404_does_not_result_in_an_err
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestGetSettingById
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestGetSettingById/Get_Setting_by_ID
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestGetSettingById/Get_Setting_by_ID_-_invalid_server_response
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestGetSettingById/Get_Setting_by_ID_-_server_response_!=_2xx
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestListKnownSettings
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/client/dtclient ‑ TestListKnownSettings/Handles_Pagination_when_listing_settings_objects
…
TestMain

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 20, 2024

E2E Test Results

    4 files  ±  0    268 suites  ±0   2s ⏱️ - 40m 19s
1 279 tests  - 674  1 278 ✅  - 671  0 💤  - 2   1 ❌  -  1 
1 359 runs   - 706  1 300 ✅  - 761  0 💤  - 2  59 ❌ +57 

For more details on these failures, see this check.

Results for commit be05806. ± Comparison against base commit ca558e3.

This pull request removes 674 tests.
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_group
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_policy
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_user
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/Wrong_environment_group
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/Wrong_environment_name
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/Wrong_project_name
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/correct_parameters
…

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman force-pushed the refactor/use-retry-logic-from-core-library branch from 16ab42b to c60b6ec Compare August 21, 2024 09:21
@arthurpitman arthurpitman added run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Aug 21, 2024
@arthurpitman arthurpitman force-pushed the refactor/use-retry-logic-from-core-library branch from be05806 to 957e281 Compare August 21, 2024 15:05
@arthurpitman arthurpitman force-pushed the refactor/use-retry-logic-from-core-library branch from 957e281 to 67f9234 Compare August 26, 2024 12:24
Copy link

sonarcloud bot commented Aug 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant