refactor: constants for api names/types #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
review dog findings can be ignored |
warber
force-pushed
the
chore/api-types-constants
branch
from
ea8abb5
to
4d0ef7a
Compare
E2E Test Results 4 files - 1 500 suites - 125 34m 30s ⏱️ - 22m 11s For more details on these failures, see this check. Results for commit 4d0ef7a. ± Comparison against base commit 2c23ed9. This pull request removes 2 tests. |
arthurpitman
approved these changes
Feb 29, 2024
warber
force-pushed
the
chore/api-types-constants
branch
from
4d0ef7a
to
8d1a088
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
This PR just extracts the values for classic config names into their own constants to reduce the risk of having typos and searching unnecessarily for errors for quite some time