Turn opmask_with_dsts()/is_evex_mask condition into an assertion. #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opmask_with_dsts() covers both Intel and AT&T syntax, non-x86 syntaxes should never have is_evex_mask == true, and DR syntax should never get into this function.
| "evex mask must always be the first source."); | ||
| CLIENT_ASSERT(opmask_with_dsts(), |
There was a problem hiding this comment.
Maybe better if this is the first thing in this if-block.
| @@ -1035,7 +1035,9 @@ instr_disassemble_opnds_noimplicit(char *buf, size_t bufsz, size_t *sofar DR_PAR | |||
| */ | |||
There was a problem hiding this comment.
and DR syntax should never get into this function.
Do we need an assert for this?
| @@ -1035,7 +1035,9 @@ instr_disassemble_opnds_noimplicit(char *buf, size_t bufsz, size_t *sofar DR_PAR | |||
| */ | |||
There was a problem hiding this comment.
Is there an issue# that this bug fixes? Either way, would be nice to note the goal (cleanup/bug-fix) in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opmask_with_dsts() covers both Intel and AT&T syntax, non-x86 syntaxes should never have is_evex_mask == true, and DR syntax should never get into this function.